Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethink Spring Cloud Stream Zipkin integration #555

Closed
adriancole opened this issue Apr 6, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@adriancole
Copy link
Contributor

commented Apr 6, 2017

Spring Cloud Sleuth Stream Zipkin is very different than the rest of sleuth code as it is a custom server. I think it would be best to pull this into a separate repo which includes at least the collector side, if not also the sender side. This would be similar to zipkin-aws where SQS a custom transport can be plugged into a vanilla zipkin server (and any tracer for that matter)

https://github.com/openzipkin/zipkin-aws/tree/master/autoconfigure/collector-sqs#running

Most zipkin integrations do not require a custom build, rather custom assembly. For example, zipkin-aws and zipkin-azure layer autoconfiguration on top of the base server. This allows people to mix and match things, for example using a kafka collector, but a google cloud storage. Importantly, this allows people to compose servers in their tool of choice, albeit docker, puppet, chef or doit.sh without a custom build.

There's only one catch to this, which is that the maven setting (module) used there has been removed in spring boot 1.5 (openzipkin/zipkin-aws#32). Across all projects we would need a similar remedy to that.

cc @dsyer

@marcingrzejszczak

This comment has been minimized.

Copy link
Contributor

commented Oct 23, 2017

It was rethought in a very brutal way :P #727

@marcingrzejszczak marcingrzejszczak added this to the 2.0.0.M3 milestone Oct 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.