Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different versions of Spring Cloud with the same code show different effects on zipkin #898

Closed
jumkey opened this issue Mar 10, 2018 · 6 comments

Comments

@jumkey
Copy link

jumkey commented Mar 10, 2018

When i use Spring Boot 2.0.0.RELEASE&Spring Cloud Finchley.M8 zipkin show like this
20180310232818

but change to Spring Cloud Edgware.SR2&Spring Boot 1.5.10.RELEASE or use Rest Template don't have the last demo2
20180310232953

I think it might be a bug

@marcingrzejszczak
Copy link
Contributor

Can you

  • explain where do you think that there's a bug
  • try latest finchley snapshots
  • show the code (I have no idea what and how exactly you're doing things)

@jumkey
Copy link
Author

jumkey commented Mar 10, 2018

This is demo2 code

@RestController
public class Demo2Controller {
    @Autowired
    private UserClient userClient;
    @Autowired
    private RestTemplate restTemplate;

    @RequestMapping(value = "login",method = RequestMethod.GET)
    public void login(){
        restTemplate.getForEntity("http://localhost:8080/s",Boolean.class).getBody();

        userClient.isLogin();//FeignClient http://localhost:8080/s
    }
}

http://localhost:8080/s is just return true

use FeignClient has more span

because of poor network i have not try latest snapshots

@marcingrzejszczak
Copy link
Contributor

To help you, you'll have to upload the whole sample. I don't understand what you're trying to achieve, I still don't understand where the "bug" is.

@jumkey
Copy link
Author

jumkey commented Mar 10, 2018

the same service call by RestTemplate and FeignClient have different number of spans is it correct?

@jumkey
Copy link
Author

jumkey commented Mar 10, 2018

demo code

@RestController
public class UserResource implements UserClient {

    @Override
    public Boolean isLogin() {
        return true;
    }
}

demo didn't call demo2
but zipkin show

demo-->demo2

@marcingrzejszczak
Copy link
Contributor

Please upload your whole project to github. Until you do so I'm closing this issue cause i can't really guess what you're doing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants