Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarifies that Kafka span transport also requires a property to be set. #1013

Merged
merged 1 commit into from Jun 19, 2018

Conversation

@adriancole
Copy link
Contributor

adriancole commented Jun 19, 2018

No description provided.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jun 19, 2018

Codecov Report

Merging #1013 into master will increase coverage by 0.57%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1013      +/-   ##
============================================
+ Coverage     70.86%   71.43%   +0.57%     
- Complexity      628      635       +7     
============================================
  Files           119      119              
  Lines          2797     2797              
  Branches        298      298              
============================================
+ Hits           1982     1998      +16     
+ Misses          620      605      -15     
+ Partials        195      194       -1
Impacted Files Coverage Δ Complexity Δ
...h/instrument/reactor/SpanSubscriptionProvider.java 92.85% <0%> (+7.14%) 6% <0%> (+1%) ⬆️
...cloud/sleuth/instrument/reactor/ReactorSleuth.java 57.14% <0%> (+11.9%) 11% <0%> (+1%) ⬆️
.../sleuth/instrument/reactor/LazySpanSubscriber.java 62.5% <0%> (+62.5%) 5% <0%> (+5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e43c35...d24523f. Read the comment docs.

@marcingrzejszczak marcingrzejszczak merged commit da1df97 into master Jun 19, 2018
4 checks passed
4 checks passed
ci/circleci Your tests passed on CircleCI!
Details
ci/pivotal-cla Thank you for signing the Contributor License Agreement!
Details
codecov/patch Coverage not affected when comparing 9e43c35...d24523f
Details
codecov/project 71.43% (+0.57%) compared to 9e43c35
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.