Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added rate limit sampler via a property #1175

Closed
wants to merge 3 commits into from

Conversation

Projects
None yet
3 participants
@marcingrzejszczak
Copy link
Contributor

commented Jan 6, 2019

fixes gh-1162

@marcingrzejszczak

This comment has been minimized.

Copy link
Contributor Author

commented Jan 6, 2019

marcingrzejszczak added some commits Jan 6, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Jan 6, 2019

Codecov Report

Merging #1175 into master will decrease coverage by 0.21%.
The diff coverage is 68.75%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #1175      +/-   ##
===========================================
- Coverage     69.91%   69.7%   -0.22%     
- Complexity      757     764       +7     
===========================================
  Files           138     140       +2     
  Lines          3444    3456      +12     
  Branches        373     373              
===========================================
+ Hits           2408    2409       +1     
- Misses          822     833      +11     
  Partials        214     214
Impacted Files Coverage Δ Complexity Δ
.../cloud/sleuth/zipkin2/ZipkinAutoConfiguration.java 100% <ø> (ø) 5 <0> (ø) ⬇️
...mework/cloud/sleuth/sampler/SamplerProperties.java 100% <100%> (ø) 5 <2> (+2) ⬆️
...work/cloud/sleuth/sampler/RateLimitingSampler.java 60% <60%> (ø) 2 <2> (?)
...cloud/sleuth/sampler/SamplerAutoConfiguration.java 62.5% <62.5%> (ø) 3 <3> (?)
...ing/TracingConnectionFactoryBeanPostProcessor.java 67.85% <0%> (-5.36%) 6% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26dc5be...6149307. Read the comment docs.

@adriancole

This comment has been minimized.

Copy link
Contributor

commented Jan 6, 2019

@marcingrzejszczak

This comment has been minimized.

Copy link
Contributor Author

commented Jan 7, 2019

fixed via 2579e78

@marcingrzejszczak marcingrzejszczak deleted the issues_#1162_ratelimit branch Jan 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.