Drops zipkin dependency from spring-cloud-sleuth-core #1649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was emmense work to prepare for decoupling of spring-cloud-sleuth-core from Zipkin. This included complete test conversion and deprecations between 2.2.x and 3.0.x. This moves all Zipkin related code to spring-cloud-sleuth-zipkin, making the primary data recording tool `SpanHandler` as opposed to `Reporter<zipkin2.Span>` For example, Wavefront and soon Stackdriver can implement `SpanHandler` and skip conversion into the Zipkin model first. `SpanHandler` also includes begin and end hooks which allow data extensions to be developed. see https://github.com/wavefrontHQ/wavefront-spring-boot
Codecov Report
@@ Coverage Diff @@
## master #1649 +/- ##
=========================================
Coverage 59.30% 59.31%
+ Complexity 768 767 -1
=========================================
Files 134 134
Lines 4141 4144 +3
Branches 487 489 +2
=========================================
+ Hits 2456 2458 +2
- Misses 1459 1462 +3
+ Partials 226 224 -2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was emmense work to prepare for decoupling of spring-cloud-sleuth-core
from Zipkin. This included complete test conversion and deprecations between
2.2.x and 3.0.x.
This moves all Zipkin related code to spring-cloud-sleuth-zipkin, making the
primary data recording tool
SpanHandleras opposed toReporter<zipkin2.Span>For example, Wavefront and soon Stackdriver can implement
SpanHandlerandskip conversion into the Zipkin model first.
SpanHandleralso includesbegin and end hooks which allow data extensions to be developed.
see https://github.com/wavefrontHQ/wavefront-spring-boot