Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drops zipkin dependency from spring-cloud-sleuth-core #1649

Merged
merged 1 commit into from May 19, 2020

Conversation

codefromthecrypt
Copy link

There was emmense work to prepare for decoupling of spring-cloud-sleuth-core
from Zipkin. This included complete test conversion and deprecations between
2.2.x and 3.0.x.

This moves all Zipkin related code to spring-cloud-sleuth-zipkin, making the
primary data recording tool SpanHandler as opposed to Reporter<zipkin2.Span>

For example, Wavefront and soon Stackdriver can implement SpanHandler and
skip conversion into the Zipkin model first. SpanHandler also includes
begin and end hooks which allow data extensions to be developed.

see https://github.com/wavefrontHQ/wavefront-spring-boot

There was emmense work to prepare for decoupling of spring-cloud-sleuth-core
from Zipkin. This included complete test conversion and deprecations between
2.2.x and 3.0.x.

This moves all Zipkin related code to spring-cloud-sleuth-zipkin, making the
primary data recording tool `SpanHandler` as opposed to `Reporter<zipkin2.Span>`

For example, Wavefront and soon Stackdriver can implement `SpanHandler` and
skip conversion into the Zipkin model first. `SpanHandler` also includes
begin and end hooks which allow data extensions to be developed.

see https://github.com/wavefrontHQ/wavefront-spring-boot
@codecov
Copy link

codecov bot commented May 18, 2020

Codecov Report

Merging #1649 into master will increase coverage by 0.00%.
The diff coverage is 75.51%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1649   +/-   ##
=========================================
  Coverage     59.30%   59.31%           
+ Complexity      768      767    -1     
=========================================
  Files           134      134           
  Lines          4141     4144    +3     
  Branches        487      489    +2     
=========================================
+ Hits           2456     2458    +2     
- Misses         1459     1462    +3     
+ Partials        226      224    -2     
Impacted Files Coverage Δ Complexity Δ
...loud/sleuth/autoconfig/TraceAutoConfiguration.java 93.33% <ø> (+14.38%) 15.00 <0.00> (-9.00) ⬆️
.../cloud/sleuth/zipkin2/ZipkinAutoConfiguration.java 78.82% <75.51%> (-4.51%) 17.00 <9.00> (+9.00) ⬇️
...cloud/sleuth/instrument/reactor/ReactorSleuth.java 46.66% <0.00%> (-11.12%) 8.00% <0.00%> (-1.00%)
.../sender/ZipkinRestTemplateSenderConfiguration.java 82.53% <0.00%> (+3.17%) 4.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31fb300...04f5cc1. Read the comment docs.

@codefromthecrypt codefromthecrypt merged commit 4ed3db9 into master May 19, 2020
@codefromthecrypt codefromthecrypt deleted the no-zipkin-dep branch May 19, 2020 00:22
@marcingrzejszczak marcingrzejszczak added this to the 3.0.0.M2 milestone May 20, 2020
@marcingrzejszczak marcingrzejszczak added this to In progress in 2020.0.0-M2 via automation May 20, 2020
@spencergibb spencergibb moved this from In progress to Done in 2020.0.0-M2 May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
2020.0.0-M2
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants