Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to Zipkin 1.8.4 #392

Merged
merged 1 commit into from Sep 6, 2016
Merged

Updates to Zipkin 1.8.4 #392

merged 1 commit into from Sep 6, 2016

Conversation

codefromthecrypt
Copy link
Contributor

Luckily, someone reported a bug where if unprintable characters were in
the json, the UI would hose. This version fixes that.

@marcingrzejszczak
Copy link
Contributor

:shipit:

@codefromthecrypt
Copy link
Contributor Author

sadly I goofed.. waiting for 1.8.4
openzipkin/zipkin#1275

On Mon, Sep 5, 2016 at 10:27 PM, Marcin Grzejszczak <
notifications@github.com> wrote:

[image: :shipit:]


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#392 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAD612Yw6wnB0j0wmXppE-lxKWOxTSoyks5qnCbQgaJpZM4J1Hg7
.

Luckily, someone reported a bug where if unprintable characters were in
the json, the UI would hose. This version fixes that.
@codecov-io
Copy link

codecov-io commented Sep 5, 2016

Current coverage is 74.59% (diff: 100%)

Merging #392 into master will not change coverage

@@             master       #392   diff @@
==========================================
  Files           130        130          
  Lines          2799       2799          
  Methods           0          0          
  Messages          0          0          
  Branches        399        399          
==========================================
  Hits           2088       2088          
  Misses          533        533          
  Partials        178        178          

Powered by Codecov. Last update 20d2144...3b4e70e

@codefromthecrypt codefromthecrypt changed the title Updates to Zipkin 1.8.3 Updates to Zipkin 1.8.4 Sep 6, 2016
@codefromthecrypt codefromthecrypt merged commit 6c8cfd5 into master Sep 6, 2016
@codefromthecrypt codefromthecrypt deleted the zipkin-1.8.3 branch September 6, 2016 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants