Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Sleuth now uses Brave #829
with this pull request we have rewritten the whole Sleuth internals to use Brave. That way we can leverage all the functionalities & instrumentations that Brave already has (https://github.com/openzipkin/brave/tree/master/instrumentation).
Migration guide is available here: https://github.com/spring-cloud/spring-cloud-sleuth/wiki/Spring-Cloud-Sleuth-2.0-Migration-Guide
fixes #711 - Brave instrumentation
What's done? - Web Server - Simple handler interceptor - Web Clients - RestTemplate - Slf4j - with Brave in place it will also work for any other implementation (e.g. log4j) In progress TraceCallable and TraceRunnable in order to then do stuff with asyncs and then eventually callable on mvc to make the next samples pass.
there's still the issue546 package to copy but it requires instrumentation of async rest template etc. For now, the goal is to make the async servlet support work
can't make org.springframework.cloud.brave.instrument.web.TraceWebAsyncClientAutoConfigurationTests pass due to missing client side spans. That's because the `finish()` method in brave returns a null span and the `reporter` is not called.