Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Allow kafka-streams binder to consume messages from multiple kafka topics #362
This is a proposal to fix the issue #361.
While this might work fine for the Kafka Streams binder, I think there needs to be a more general solution for all binders that can support consuming from multiple topics (kafka, rabbitmq etc message channel binders, where the listener containers can be configured to consume from a lis of topics/queues).
Thank you Soby…
On Tue, Apr 24, 2018 at 3:49 AM, Soby Chacko ***@***.***> wrote: Hi @sarathshyam <https://github.com/sarathshyam> - We are actively reviewing this PR. We might have to take a slightly different approach or add some extra changes at the core framework level to address this scenario. We will update soon on this PR about any progress. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#362 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGXNr7qKboLkuUqo8m696SiC-tPaokhRks5trlOMgaJpZM4TVCzd> .
referenced this pull request
Apr 24, 2018
@sarathshyam Thank you for the PR. This is merged upstream. A couple of notes related to this change. We introduced a new property at the core consumer level called
Once this change was in the core framework, I added two more commits on top of your commit in the kafka streams binder. The following changes are introduced through those 2 commits.
I did not squash the 2 commits that I added in the PR as they have individual focus but related to your base commit.
Once again, thank you. Looking forward to more PR's in the future!