Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider truncating the stack trace header if it exceeds the frame_max negotiated with the broker #159

Closed
garyrussell opened this issue Jun 21, 2018 · 1 comment
Assignees
Milestone

Comments

@garyrussell
Copy link
Contributor

@garyrussell garyrussell commented Jun 21, 2018

Connection.getFrameMax().

See Stack Overflow.

Headers are not fragmented; perhaps we should consider truncating the stack trace if the negotiated frame_max is exceeded (and log a WARN).

I suspect a truncated stack trace is better than a failure to publish at all.

@sabbyanandan sabbyanandan added this to the 2.1.x milestone Jun 25, 2018
@sabbyanandan sabbyanandan modified the milestones: 2.1.x, 2.1.0.M2 Jul 9, 2018
@sabbyanandan sabbyanandan added the ready label Jul 9, 2018
@garyrussell

This comment has been minimized.

Copy link
Contributor Author

@garyrussell garyrussell commented Jul 9, 2018

This needs to wait until the next boot release; the supporting code will be in Spring AMQP 2.0.5.

@garyrussell garyrussell removed the ready label Jul 9, 2018
garyrussell added a commit to garyrussell/spring-cloud-stream-binder-rabbit that referenced this issue Jul 26, 2018
garyrussell added a commit to garyrussell/spring-cloud-stream-binder-rabbit that referenced this issue Jul 26, 2018
@garyrussell garyrussell added in pr and removed in progress labels Jul 26, 2018
@olegz olegz modified the milestones: 2.1.0.M2, 2.1.x Aug 28, 2018
@sabbyanandan sabbyanandan modified the milestones: 2.1.x, 2.1.0.M3 Sep 11, 2018
@olegz olegz modified the milestones: 2.1.0.M3, 2.1.0.RC1 Sep 21, 2018
garyrussell added a commit to garyrussell/spring-cloud-stream-binder-rabbit that referenced this issue Oct 3, 2018
@olegz olegz closed this in 3615664 Oct 3, 2018
@sabbyanandan sabbyanandan removed the in pr label Oct 3, 2018
@olegz olegz self-assigned this Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.