RabbitMQ - GH-43 - Support Fix For Routing Key #801
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbogoevici
reviewed
Feb 13, 2017
| @@ -194,8 +194,7 @@ public void testPartitionedModuleSpEL() throws Exception { | |||
| Binding<MessageChannel> outputBinding = binder.bindProducer("part.0", output, producerProperties); | |||
| try { | |||
| Object endpoint = extractEndpoint(outputBinding); | |||
| assertThat(getEndpointRouting(endpoint)) | |||
| .contains(getExpectedRoutingBaseDestination("part.0", "test") + "-' + headers['partition']"); | |||
| checkRkExpression(endpoint); | |||
There was a problem hiding this comment.
Do we want to use this name or something more expressive?
|
Merged in master via 51a7f8b |
So, let's close then ! 😄 |
|
@artembilan I was waiting for a confirmation whether we want to backport or not. |
|
Cherry-picked as 8056473 |
sobychacko
added a commit
to sobychacko/spring-cloud-stream
that referenced
this pull request
Feb 24, 2022
* Kafka Streams - DLQ control per consumer binding Resolves spring-cloud/spring-cloud-stream-binder-kafka#800 * Fine-grained DLQ control and deserialization exception handlers per input binding * Deprecate KafkaStreamsBinderConfigurationProperties.SerdeError in preference to the new enum `KafkaStreamsBinderConfigurationProperties.DeserializationExceptionHandler` based properties * Add tests, modifying docs * Addressing PR review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See spring-cloud/spring-cloud-stream-binder-rabbit#43