Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Vault's database backend #169

Closed
christophetd opened this issue Oct 20, 2017 · 2 comments
Milestone

Comments

@christophetd
Copy link

@christophetd christophetd commented Oct 20, 2017

Hi,

The MySQL / PostegreSQL / ... secret backends are now deprecated in Vault in favor of the more generic database secret backend introduced in v0.7.1.

The Spring Cloud Vault documentation doesn't mention it anywhere, and it looks like it only supports those deprecated backends.

Are there any plans support the new database secret backend?

Thanks.

mp911de added a commit that referenced this issue Oct 20, 2017
mp911de added a commit that referenced this issue Oct 20, 2017
@mp911de

This comment has been minimized.

Copy link
Member

@mp911de mp911de commented Oct 20, 2017

The database backend is fully supported. It responds with username and password like the deprecated vendor-specific backends. Setting spring.cloud.vauld.mysql.backend=database is sufficient to use the database backend.

For 2.0, it would make sense to deprecate our PostreSQL and MySQL configuration properties in favor of a dedicated JDBC database configuration configured to the database backend.

@mp911de mp911de added this to the 2.0.0 milestone Oct 20, 2017
@mp911de

This comment has been minimized.

Copy link
Member

@mp911de mp911de commented Oct 23, 2017

See #170.

mp911de added a commit that referenced this issue Oct 27, 2017
Use the legacy plugin to generate shorter user names (required for the MySQL version used on TravisCI).

See gh-169.
mp911de added a commit that referenced this issue Oct 27, 2017
Use the legacy plugin to generate shorter user names (required for the MySQL version used on TravisCI).

See gh-169.
@mp911de mp911de changed the title Support for Vault database secret backend? Add support for Vault's database backend Oct 27, 2017
@mp911de mp911de modified the milestones: 2.0.0 RC1, 2.0.0 M3 Oct 27, 2017
mp911de added a commit that referenced this issue Oct 27, 2017
We now support Vault's database backend directly. MySQL and PostgreSQL configuration properties are deprecated now in favor of spring.cloud.vault.database. Cassandra and MongoDB backends remain active and default to their deprecated backends to support multi-database configuration of multiple, various database types.

spring.cloud.vault:
    database:
        enabled: true
        role: readonly

Original pull request: gh-170.
Related ticket: gh-169.
mp911de added a commit that referenced this issue Oct 27, 2017
Convert spaces to tabs. Deprecate VaultPostgreSqlProperties and VaultMySqlProperties. Convert database integration test to use MySQL. Slightly reword reference documentation.

Upgrade lombok to 1.16.18 to use onMethod_ attributes.

Original pull request: gh-170.
Related ticket: gh-169.
@mp911de mp911de closed this Oct 27, 2017
nwarnke pushed a commit to nwarnke/spring-cloud-vault that referenced this issue Feb 27, 2019
We now retain the JSON data type in the property source. This change requires property transformers to accept/produce a Map of String to Object whereas it was String to String before.

See spring-cloudgh-169.
nwarnke pushed a commit to nwarnke/spring-cloud-vault that referenced this issue Feb 27, 2019
Remove PropertyTransformerSupport in favor of default method in PropertyTransformer and refactor PropertyTransformer to functional interface.

See spring-cloudgh-169.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.