integrate Asciidoctor Tabs into UI; only use if extension is registered #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mojavelinux
commented
Nov 16, 2022
mojavelinux
commented
- rename tabs.js and tabs.css to spring-tabs.js and spring-tabs.css, respectively
- remove duplicate spring/tabs.css
- add asciidoctor-tabs.js and asciidoctor-tabs.css
- add UI helper to detect if Asciidoctor extension is registered
- load appropriate resources (Spring or Asciidoctor variant) depending on whether @asciidoctor/tabs is registered
- allow Asciidoctor extension to be registered in UI preview
- register @asciidoctor/tabs extension by default in UI preview
mojavelinux
force-pushed
the
asciidoctor-tabs
branch
from
5b3ad9c to
890d212
Compare
mojavelinux
force-pushed
the
asciidoctor-tabs
branch
2 times, most recently
from
b923eb3 to
c45167c
Compare
- rename tabs.js and tabs.css to spring-tabs.js and spring-tabs.css, respectively - remove duplicate spring/tabs.css - add asciidoctor-tabs.js and asciidoctor-tabs.css - add UI helper to detect if Asciidoctor extension is registered - load appropriate resources (Spring or Asciidoctor variant) depending on whether @asciidoctor/tabs is registered - allow Asciidoctor extension to be registered in UI preview - define tabs-sync-option attribute on main preview page
mojavelinux
force-pushed
the
asciidoctor-tabs
branch
from
c45167c to
e5015ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.