Remove lineSeparator LF requirement

Update checkstyle rules so that the `NewlineAtEndOfFile` check no longer enforces only LF line separators. The default now accepts LF, CR or CRLF. Closes gh-202
spring-io · Aug 24, 2020 · 0b36c1c · 0b36c1c
1 parent c03c9ea
commit 0b36c1c
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 6 deletions.
diff --git a/...yle/src/main/java/io/spring/javaformat/checkstyle/check/SpringAvoidStaticImportCheck.java b/...yle/src/main/java/io/spring/javaformat/checkstyle/check/SpringAvoidStaticImportCheck.java
@@ -26,6 +26,8 @@
 
 /**
  * Spring variant of {@link AvoidStarImportCheck}.
+ *
+ * @author Phillip Webb
  */
 public class SpringAvoidStaticImportCheck extends AvoidStaticImportCheck {
 

diff --git a/...ormat-checkstyle/src/main/resources/io/spring/javaformat/checkstyle/spring-checkstyle.xml b/...ormat-checkstyle/src/main/resources/io/spring/javaformat/checkstyle/spring-checkstyle.xml
@@ -11,9 +11,7 @@
 		<property name="headerFile" value="${headerFile}" default=""/>
 		<property name="headerCopyrightPattern" value="${headerCopyrightPattern}"/>
 	</module>
-	<module name="com.puppycrawl.tools.checkstyle.checks.NewlineAtEndOfFileCheck">
-		<property name="lineSeparator" value="lf"/>
-	</module>
+	<module name="com.puppycrawl.tools.checkstyle.checks.NewlineAtEndOfFileCheck" />
 
 	<!-- TreeWalker Checks -->
 	<module name="com.puppycrawl.tools.checkstyle.TreeWalker">

diff --git a/src/checkstyle/checkstyle.xml b/src/checkstyle/checkstyle.xml
@@ -8,9 +8,7 @@
 		<property name="headerFile" value="${checkstyle.header.file}" />
 		<property name="fileExtensions" value="java" />
 	</module>
-	<module name="com.puppycrawl.tools.checkstyle.checks.NewlineAtEndOfFileCheck">
-		<property name="lineSeparator" value="lf"/>
-	</module>
+	<module name="com.puppycrawl.tools.checkstyle.checks.NewlineAtEndOfFileCheck" />
 
 	<!-- TreeWalker Checks -->
 	<module name="com.puppycrawl.tools.checkstyle.TreeWalker">