New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tc server] selecting "serve modules without publishing" option is failing with exception. #8

Closed
lak-proddev opened this Issue Jun 26, 2018 · 6 comments

Comments

Projects
None yet
3 participants
@lak-proddev
Contributor

lak-proddev commented Jun 26, 2018

selecting serve modules without publishing option is failing with exception.
See below SS

Loader jar not found for server ID: org.eclipse.jst.server.tomcat.runtime.90.

image

@BoykoAlex

This comment has been minimized.

Contributor

BoykoAlex commented Jun 26, 2018

should be fixed now

@BoykoAlex BoykoAlex closed this Jun 26, 2018

@lak-proddev

This comment has been minimized.

Contributor

lak-proddev commented Jun 26, 2018

Thanks for the fix. But, the commit only fixes the exception. Actual option doesn't work properly.

I think, this issue will be fixed by overriding this method in tc server code.
org.eclipse.jst.server.tomcat.core.internal.TomcatServerBehaviour.publishFinish(IProgressMonitor)

We need to map tc server id to tomcat runtime Id.

See this line

TomcatServerBehaviour.java
line 352

String tomcatVersion = TomcatVersionHelper.getCatalinaVersion(getServer().getRuntime().getLocation(), serverTypeID);

com.vmware.vfabric.ide.eclipse.tcserver.internal.core.TcServerVersionHandler.mapToTomcatRuntimeId(IPath, String)

@BoykoAlex

This comment has been minimized.

Contributor

BoykoAlex commented Jun 26, 2018

Hopefully fixed now. Since you're diving into the source code feel free to create PRs for stuff you find not working. We'll gladly merge them :-)

FYI: I see that deploying to tc server 3.x with tomcat 7.0.x isn't working but everything else seems to be in order. Looking into it now.

@BoykoAlex

This comment has been minimized.

Contributor

BoykoAlex commented Jun 26, 2018

NVM, it deploys fine, just need to create proper boot app

@lak-proddev

This comment has been minimized.

Contributor

lak-proddev commented Jun 27, 2018

Still, I couldn't deploy application. I think, this would be the fix.

Issue-8tc-server-selecting-serve-modules-without-pub.txt

@martinlippert

This comment has been minimized.

Member

martinlippert commented Jun 27, 2018

Would you be interested in submitting this as a pull request? In case so, please make sure to read the guidelines for contributing code and sign the contributors license agreement: https://github.com/spring-projects/eclipse-integration-tcserver/blob/master/CONTRIBUTING.adoc

That would be fantastic!!!

lak-proddev added a commit to lak-proddev/eclipse-integration-tcserver that referenced this issue Jun 27, 2018

[Issue spring-projects#8] [tc server] selecting "serve modules withou…
…t publishing"

option is failing with exception.

BoykoAlex added a commit that referenced this issue Jun 27, 2018

Merge pull request #9 from lak-proddev/master
[Issue #8] [tc server] selecting "serve modules without publishing" option is failing with exception.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment