Problems with DefaultTools overloading, and SyncMcpToolCallbackProvider cannot be injected automatically

[Inhenry]

Env:

When I configure the MCP client side using the Auto configuration, only List < McpClients > can find the bean and inject it; but SyncMcpToolCallbackProvider shows that the bean class is not found, unlike a reference archive (although ToolCallBackProvider types of beans can be injected).

In addition, if I use mcpclient's listTools () directly, the overload of .defaultTools() will also choose the parameter Object, causing the tool to fail.
The solution is that .defaultTools ()/.tools () must pass parameters of the form ToolCallback

[jamesward]

Ran into this as well in M7. Docs seem wrong:
https://docs.spring.io/spring-ai/reference/1.0/api/mcp/mcp-client-boot-starter-docs.html#_usage_example

Also IntelliJ can't resolve the spring.ai.mcp.client.toolcallback.enabled property.

[argmnt]

I also ran into same issue with version M7

[markpollack]

ok, I think we need to address the missing callback as in this PR. #2931

we need a new issue for that.

as for the original issue, what about this naming scheme?

current

	ChatClientRequestSpec tools(String... toolNames);

		ChatClientRequestSpec tools(ToolCallback... toolCallbacks);

		ChatClientRequestSpec tools(List<ToolCallback> toolCallbacks);

		ChatClientRequestSpec tools(Object... toolObjects);

		ChatClientRequestSpec tools(ToolCallbackProvider... toolCallbackProviders);

proposed

ChatClientRequestSpec tools(Object... toolObjects);

ChatClientRequestSpec toolNames(String... toolNames);




// For ToolCallback varargs - specific callback implementations 
ChatClientRequestSpec toolCallbacks(ToolCallback... toolCallbacks);

// For List of ToolCallback - similar to above but as a collection
ChatClientRequestSpec toolCallbacks(List<ToolCallback> toolCallbacks);


// For ToolCallbackProvider varargs - factory/provider pattern
ChatClientRequestSpec toolCallbacks(ToolCallbackProvider... toolCallbackProviders);

[ThomasVitale]

I like the proposed solution.

[ThomasVitale]

Another issue reporting the same problem: #2495

[Inhenry]

Another issue reporting the same problem: #2495

Thanks for pointing that out! I initially ran into the missing callback issue when passing McpClient.listTools() directly as the defaultTools parameter. But yes, it's effectively the same as #2495

I like the proposed solution.

ditto

[markpollack]

method name changes for tools is done and added info to the upgrade-notes.adoc merged in 091fca2