From 1e68862142c24837c9d993a37ffde40b6085f52c Mon Sep 17 00:00:00 2001 From: Ilayaperumal Gopinathan Date: Fri, 20 Dec 2024 20:29:40 +0000 Subject: [PATCH] Fix SimpleVectorStore' deprecated constructor use - Use SimpleVectorStoreBuilder for SimpleVectorStore instance creation --- .../test/java/org/springframework/ai/openai/acme/AcmeIT.java | 2 +- .../ai/openai/vectorstore/SimplePersistentVectorStoreIT.java | 4 ++-- .../ai/vectorstore/SimpleVectorStoreTests.java | 2 +- .../springframework/ai/integration/tests/TestApplication.java | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/models/spring-ai-openai/src/test/java/org/springframework/ai/openai/acme/AcmeIT.java b/models/spring-ai-openai/src/test/java/org/springframework/ai/openai/acme/AcmeIT.java index 2701a2fe8c8..9cda24f4bfb 100644 --- a/models/spring-ai-openai/src/test/java/org/springframework/ai/openai/acme/AcmeIT.java +++ b/models/spring-ai-openai/src/test/java/org/springframework/ai/openai/acme/AcmeIT.java @@ -82,7 +82,7 @@ void acmeChain() { // Step 2 - Create embeddings and save to vector store logger.info("Creating Embeddings..."); - VectorStore vectorStore = new SimpleVectorStore(this.embeddingModel); + VectorStore vectorStore = SimpleVectorStore.builder(this.embeddingModel).build(); vectorStore.accept(textSplitter.apply(jsonReader.get())); diff --git a/models/spring-ai-openai/src/test/java/org/springframework/ai/openai/vectorstore/SimplePersistentVectorStoreIT.java b/models/spring-ai-openai/src/test/java/org/springframework/ai/openai/vectorstore/SimplePersistentVectorStoreIT.java index 4898e4a68d6..348e800bf06 100644 --- a/models/spring-ai-openai/src/test/java/org/springframework/ai/openai/vectorstore/SimplePersistentVectorStoreIT.java +++ b/models/spring-ai-openai/src/test/java/org/springframework/ai/openai/vectorstore/SimplePersistentVectorStoreIT.java @@ -56,14 +56,14 @@ void persist() { JsonReader jsonReader = new JsonReader(this.bikesJsonResource, new ProductMetadataGenerator(), "price", "name", "shortDescription", "description", "tags"); List documents = jsonReader.get(); - SimpleVectorStore vectorStore = new SimpleVectorStore(this.embeddingModel); + SimpleVectorStore vectorStore = SimpleVectorStore.builder(this.embeddingModel).build(); vectorStore.add(documents); File tempFile = new File(this.workingDir.toFile(), "temp.txt"); vectorStore.save(tempFile); assertThat(tempFile).isNotEmpty(); assertThat(tempFile).content().contains("Velo 99 XR1 AXS"); - SimpleVectorStore vectorStore2 = new SimpleVectorStore(this.embeddingModel); + SimpleVectorStore vectorStore2 = SimpleVectorStore.builder(this.embeddingModel).build(); vectorStore2.load(tempFile); List similaritySearch = vectorStore2.similaritySearch("Velo 99 XR1 AXS"); diff --git a/spring-ai-core/src/test/java/org/springframework/ai/vectorstore/SimpleVectorStoreTests.java b/spring-ai-core/src/test/java/org/springframework/ai/vectorstore/SimpleVectorStoreTests.java index f4d5d47c79b..94d9f77c59c 100644 --- a/spring-ai-core/src/test/java/org/springframework/ai/vectorstore/SimpleVectorStoreTests.java +++ b/spring-ai-core/src/test/java/org/springframework/ai/vectorstore/SimpleVectorStoreTests.java @@ -144,7 +144,7 @@ void shouldSaveAndLoadVectorStore() throws IOException { File saveFile = this.tempDir.resolve("vector-store.json").toFile(); this.vectorStore.save(saveFile); - SimpleVectorStore loadedStore = new SimpleVectorStore(this.mockEmbeddingModel); + SimpleVectorStore loadedStore = SimpleVectorStore.builder(this.mockEmbeddingModel).build(); loadedStore.load(saveFile); List results = loadedStore.similaritySearch("test content"); diff --git a/spring-ai-integration-tests/src/test/java/org/springframework/ai/integration/tests/TestApplication.java b/spring-ai-integration-tests/src/test/java/org/springframework/ai/integration/tests/TestApplication.java index df17af1fd44..3a26c71c10f 100644 --- a/spring-ai-integration-tests/src/test/java/org/springframework/ai/integration/tests/TestApplication.java +++ b/spring-ai-integration-tests/src/test/java/org/springframework/ai/integration/tests/TestApplication.java @@ -33,7 +33,7 @@ public class TestApplication { @Bean SimpleVectorStore simpleVectorStore(EmbeddingModel embeddingModel) { - return new SimpleVectorStore(embeddingModel); + return SimpleVectorStore.builder(embeddingModel).build(); } }