Skip to content

fix: SimpleVectorStoreFilterExpressionConverter incorrectly treats "in" substring inside metadata key as IN operator #4909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: SimpleVectorStoreFilterExpressionConverter incorrectly treats "in" substring inside metadata key as IN operator #4909

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ...framework/ai/vectorstore/filter/converter/SimpleVectorStoreFilterExpressionConverter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,11 @@ protected void doValue(Filter.Value filterValue, StringBuilder context) {
}
formattedList.append("}");

if (context.lastIndexOf("in ") == -1) {
String ctx = context.toString().trim();
boolean isInClause = ctx.endsWith(" in");
boolean isNotInClause = ctx.endsWith(" not in");

if (!isInClause && !isNotInClause) {
context.append(formattedList);
}
else {
Expand Down
13 changes: 13 additions & 0 deletions ...work/ai/vectorstore/filter/converter/SimpleVectorStoreFilterExpressionConverterTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,4 +217,17 @@ public void testComplexIdentifiers() {
Assertions.assertEquals(Boolean.TRUE, parser.parseExpression(vectorExpr).getValue(context, Boolean.class));
}

@Test
void eqExpressionWithListAndKeyContainingInSpaceShouldNotUseContains() {
Filter.Expression expr = new Filter.Expression(
Filter.ExpressionType.EQ,
new Filter.Key("pin code"),
new Filter.Value(List.of("1234", "5678"))
);

String result = converter.convertExpression(expr);

Assertions.assertEquals("#metadata['pin code'] == {'1234','5678'}", result);
}

}