Set Log4J dependency from runtime to compile in log4j module as we are re #4

Merged
merged 1 commit into from Oct 17, 2011

Conversation

Projects
None yet
2 participants
Contributor

ealden commented Sep 18, 2011

Set Log4J dependency from runtime to compile in log4j module as we are referencing org.apache.log4j.Level in our code

We are getting compile errors in the log4j module, as it has the Log4J
dependency set to runtime but is referencing org.apache.log4j.Level in
the code. Changing the dependency to compile (removing ) fixes
this problem, as the dependency is now available during compile time
where it is needed.

Alternatively, all references to org.apache.log4j.Level could be removed,
which should allow us to put the log4j dependency back to runtime. Such
change is not covered in this patch.

Signed-off-by: Ealden Esto E. Escanan ealden@gmail.com

Ealden Esto E. Escanan Set Log4J dependency from runtime to compile in log4j module as we ar…
…e referencing org.apache.log4j.Level in our code

We are getting compile errors in the log4j module, as it has the Log4J
dependency set to runtime but is referencing org.apache.log4j.Level in
the code.  Changing the dependency to compile (removing <scope />) fixes
this problem, as the dependency is now available during compile time
where it is needed.

Alternatively, all references to org.apache.log4j.Level could be removed,
which should allow us to put the log4j dependency back to runtime.  Such
change is not covered in this patch.

Signed-off-by: Ealden Esto E. Escanan <ealden@gmail.com>
6dffc6b

dsyer merged commit a66530f into spring-projects:master Oct 17, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment