Permalink
Commits on Sep 24, 2016
  1. Fix Bamboo Badge

    garyrussell committed on GitHub Sep 24, 2016
Commits on Sep 23, 2016
  1. AMQP-639: Add DirectRabbitListenerContainerFactory

    JIRA: https://jira.spring.io/browse/AMQP-639
    
    Pull common properties up to the abstract factory.
    
    Some simple polishing
    garyrussell committed with artembilan Sep 22, 2016
Commits on Sep 22, 2016
  1. AMQP-636: Queue Declaration and Recovery

    JIRA: https://jira.spring.io/browse/AMQP-636
    
    Reworked the add/adjust queues to not backout after a failure.
    Now, failed consumers are moved to `consumersToRestart`.
    
    The idle task is now a general monitor task which periodically
    checks for dead consumers and attempts to restart them.
    
    Fix Race Condition
    
    Synchronize the shutdown on the consumersMonitor to avoid race with async start thread.
    
    Use Injected or Context Admin if Present
    
    Fix Race Condition
    
    Remove consumer from this.consumers when basicCancel is issued rather than cancelOk received.
    
    Otherwise the consumersMonitor is released and the consumer count is temporarily incorrect.
    
    Fix MissingIdRetryTests
    
    Drop spring-retry to 1.1.4
    garyrussell committed with artembilan Sep 15, 2016
  2. Fix Race in DMLC Test

    The cancellation lock was released before closing the channel and the test was
    asserting that the channel is closed.
    
    Close the channel before releasing the lock.
    garyrussell committed Sep 22, 2016
Commits on Sep 20, 2016
  1. DMLC - More Diagnostics

    Error handler test did not close channel.
    garyrussell committed Sep 20, 2016
Commits on Sep 14, 2016
  1. AMQP-642: DirecMLContainer Transaction Support

    JIRA: https://jira.spring.io/browse/AMQP-642
    
    Also switch the SMLC to use `basicNack` instead of `basicReject`.
    
    Polishing
    garyrussell committed with artembilan Sep 12, 2016
Commits on Sep 12, 2016
  1. AMQP-641: DirectMLContainer Add ErrorHandler

    JIRA: https://jira.spring.io/browse/AMQP-641
    
    Simply change `invokeListener` to `executeListener` which encapsulates
    error handling (and message post processing and de-batching logic).
    
    Fix Channel Close
    
    RabbitUtils.setPhysicalCloseRequired(true);
    
    was called on the wrong thread.
    
    Fix Test Race Condition
    
    Simple polishing according PR comments
    garyrussell committed with artembilan Sep 10, 2016
Commits on Sep 9, 2016
  1. AMQP-637 Polishing and Diagnostics

    JIRA: https://jira.spring.io/browse/AMQP-637
    
    - Don't allow queue adjustment while container is starting
    - Change BrokerRunning to @ClassRule
    - Log queue deletion in rule
    
    Polishing
    garyrussell committed with artembilan Sep 9, 2016
  2. AMQP-632: Add RabbitTemplate.getUnconfirmedCount

    JIRA: https://jira.spring.io/browse/AMQP-632
    
    It gives count of unconfirmed `Publishes` without removing from set.
    ite392 committed with artembilan Aug 12, 2016
  3. DMLC Test Diagnostics

    garyrussell committed Sep 9, 2016
  4. AbstractConnectionFactory: remove obsolete remark in javadoc

    AMQP-554 has been resolved since 1.6 M1, so this remark is now obsolete.
    tbcs committed with artembilan Sep 9, 2016
  5. AMQP-637: Fix Shutdown

    JIRA: https://jira.spring.io/browse/AMQP-637
    
    Avoid NPE
    
    Polishing
    
    Make consumer cleanup consistent across cancel and cancelOk
    garyrussell committed with artembilan Sep 9, 2016
  6. AMQP-637: DirectMLContainer - Add/Remove Queues

    JIRA: https://jira.spring.io/browse/AMQP-637
    
    Also pull up some more common properties to abstract container class.
    
    AMQP-635: Increase/Decrease Consumers
    
    Remove consumer from list after revert
    
    Polishing - PR Comments
    
    More Polishing
    
    And More Polishing
    
    Fix Test Race
    
    Remove integer boxing
    garyrussell committed with artembilan Sep 7, 2016
Commits on Sep 6, 2016
  1. AMQP-634: DirectMessageListenerContainer

    JIRA: https://jira.spring.io/browse/AMQP-634
    
    Initial commit for `DirectMessageListenerContainer` that runs the listener on
    the rabbitmq client thread.
    
    Polishing and Java 8 in Management Template
    
    Polishing - PR Comments
    
    Polishing - MessageProperties.messageCount
    
    Also make RabbitAccessor.setConnectionFactory() 'final'.
    
    Polishing - PR Comments
    
    * Polishing typos and simple code style
    garyrussell committed with artembilan Feb 29, 2016
Commits on Sep 2, 2016
  1. Clean Broker After Running Tests

    Also update S-F and spring-retry to snapshots.
    
    Remove redundant `foo` queue from `QueueParserIntegrationTests-context.xml`
    garyrussell committed with artembilan Sep 2, 2016
  2. AMQP-644: Non-Fatal Exception Stopped Container

    JIRA: https://jira.spring.io/browse/AMQP-644
    
    Previously, any `NoSuchMethodException` was container-fatal (the container was stopped)
    on the assumption that the listener was mis-configured.
    
    However, this could be a transient, data-related, problem so should be considered
    message-fatal, not container-fatal.
    
    Also added `ClassCastException` because when the `MessageListenerAdapter` delegate is a
    lambda, we get this exception instead of a `NoSuchMethodException`.
    garyrussell committed with artembilan Sep 2, 2016
Commits on Sep 1, 2016
  1. AMQP-643: Doc Polishing

    JIRA: https://jira.spring.io/browse/AMQP-643
    
    Use a Stream to filter Declarables
    garyrussell committed with artembilan Sep 1, 2016
  2. AMQP-643: Java 8 and Lambdas

    Mark functional interfaces as such.
    
    Convert many anonymous classes (mainly in tests) to lambdas.
    
    Missed One
    garyrussell committed with artembilan Aug 31, 2016
Commits on Aug 30, 2016
  1. AMQP-633: Fix What's New

    garyrussell committed Aug 30, 2016
Commits on Aug 20, 2016
  1. AMQP-633: Ensure Resources are Closed

    JIRA: https://jira.spring.io/browse/AMQP-633
    
    Close connection for non-transactional template.
    garyrussell committed Aug 20, 2016
Commits on Aug 19, 2016
  1. AMQP-633: Fix Non-Transactional Template Issue

    JIRA: https://jira.spring.io/browse/AMQP-633
    
    Previously, the `RabbitTemplate` running on a transactional container thread always
    used the consumer channel, regardless of whether the template was transactional.
    
    A non-transactional template should not use the container's transactional channel.
    
    Also some polishing around passing the connection factory into `doExecute()`.
    
    Doc - What's New
    garyrussell committed with artembilan Aug 18, 2016
Commits on Aug 15, 2016
  1. AMQP-624: Add SSL Support to Logging Appenders

    JIRA: https://jira.spring.io/browse/AMQP-624
    
    Adds the ability to configure the log4j2 and Logback
    AMQP appenders to use SSL. As it uses a RabbitConnectionFactoryBean
    to configure create the ConnectionFactory, the same options
    when configuring SSL for the factory bean are available and
    the same default values are used for the SSL configuration.
    
    Fixes log4j2 Appender. Add SSL documentation
    
    - Check boolean result for manager.activateOptions()
    - Add SSL information to logging documentation
    - Removed all deprecated log4j info.
    
    * Fix overflow for the long `clientConnectionProperties` literal in the `logging.adoc`
    steve-oakey committed with artembilan Jul 21, 2016
Commits on Aug 11, 2016
  1. AMQP-630: Migrate to Log4J2, Part II

    JIRA: https://jira.spring.io/browse/AMQP-630
    
    The previous fix wasn't full: we still need to adjust logger configs for Log4J2
    artembilan committed with garyrussell Aug 9, 2016
Commits on Aug 10, 2016
  1. Update Eclipse Code Formatter File

    Version 12, exported with STS 3.8.1
    
    ... | Preferences | Java | Code Style | Formatter | Import...
    garyrussell committed Aug 10, 2016
Commits on Jul 28, 2016
  1. AMQP-630: Move dependency from Log4j to Log4j2

    artembilan committed Jul 28, 2016
  2. AMQP-628: Master to 2.0, SF 5.0

    JIRA: https://jira.spring.io/browse/AMQP-628
    
    Remove log4j Appender (deprecated in 1.6.2).
    
    Rename/Remove Schemas
    
    Simple polishing according PR comments
    garyrussell committed with artembilan Jul 28, 2016
Commits on Jul 27, 2016
  1. AMQP-626: Add keystore\truststore type setters

    JIRA: https://jira.spring.io/browse/AMQP-626
    Fixes GH-436 (#436)
    
    Currently the `RabbitConnectionFactoryBean` has hard-coded keystore/truststore types.
    
    * Add setters for keystore/truststore types and leave previously-hardcoded as default values.
    * Add `keyStore.type` and `trustStore.type` properties for the `ssl.properties` resource
    habelson committed with artembilan Jul 27, 2016
Commits on Jul 26, 2016
  1. AMQP-625: CCF: Fix onClose Notification

    JIRA: https://jira.spring.io/browse/AMQP-625
    
    Previouly using CachingConnectionFactory with CacheMode.CHANNEL
    the connection listener `onClose` method was being notified just
    on the first time that the connection is closed.
    Now every time when the connection is closed the connection
    listener is notified.
    Marcos Costa Pinto committed with garyrussell Jul 25, 2016
Commits on Jul 18, 2016
  1. Some dependencies minor upgrades

    Fix JUnit deprecation message and some code reformatting for `MessageListenerContainerRetryIntegrationTests`
    artembilan committed Jul 18, 2016