Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-967: Use `ChannelProxy` CL instead of context #968

Merged
merged 2 commits into from Apr 5, 2019

Conversation

@artembilan
Copy link
Member

artembilan commented Apr 4, 2019

Fixes #967

Cherry-pick to 2.1.x

Fixes #967

**Cherry-pick to 2.1.x**
@garyrussell

This comment has been minimized.

Copy link
Member

garyrussell commented Apr 4, 2019

Checkstyle

@garyrussell

This comment has been minimized.

Copy link
Member

garyrussell commented Apr 4, 2019

org.springframework.amqp.rabbit.annotation.EnableRabbitIntegrationTests > deadLetterOnDefaultExchange FAILED
    org.junit.ComparisonFailure at EnableRabbitIntegrationTests.java:739
org.springframework.amqp.rabbit.annotation.ComplexTypeJsonIntegrationTests > executionError FAILED
    java.lang.IllegalStateException
        Caused by: org.springframework.context.ApplicationContextException
            Caused by: org.springframework.amqp.AmqpIllegalStateException
                Caused by: org.springframework.amqp.rabbit.listener.QueuesNotAvailableException
                    Caused by: org.springframework.amqp.rabbit.listener.BlockingQueueConsumer$DeclarationException
                        Caused by: java.io.IOException
                            Caused by: com.rabbitmq.client.ShutdownSignalException
                                Caused by: com.rabbitmq.client.ShutdownSignalException
@artembilan

This comment has been minimized.

Copy link
Member Author

artembilan commented Apr 4, 2019

Doesn't fail for me locally:

изображение

I guess this is the same SF Testing issue.
So, locally I don't have a fresh version.

But that all doesn't mean that we are good to merge, since it is going to fail on CI server anyway.

@garyrussell

This comment has been minimized.

Copy link
Member

garyrussell commented Apr 4, 2019

Yeah - I figured that after I added the comment; not worth merging anything until the issue is resolved.

@artembilan

This comment has been minimized.

Copy link
Member Author

artembilan commented Apr 5, 2019

So, it's green finally on Travis. 😄

@garyrussell garyrussell merged commit ae7b6ac into spring-projects:master Apr 5, 2019
2 checks passed
2 checks passed
ci/pivotal-cla Thank you for signing the Contributor License Agreement!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
garyrussell added a commit that referenced this pull request Apr 5, 2019
* GH-967: Use `ChannelProxy` CL instead of context

Fixes #967

**Cherry-pick to 2.1.x**

* * Remove unused imports
@garyrussell

This comment has been minimized.

Copy link
Member

garyrussell commented Apr 5, 2019

Cherry-picked as 85ddd28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.