Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a DataFieldMaxValueIncrementer that works with MySQL InnoDB table [BATCH-2566] #1038

Closed
spring-issuemaster opened this issue Jan 6, 2017 · 5 comments

Comments

@spring-issuemaster
Copy link
Collaborator

@spring-issuemaster spring-issuemaster commented Jan 6, 2017

Thomas Risberg opened BATCH-2566 and commented

Add a new DataFieldMaxValueIncrementer that can be used with MySQL InnoDB table when the ISAM engine is not available. The sequence/incrementer table functionality depends on non-transactional updates to the sequence table.


Referenced from: commits 74ab106

Backported to: 4.0.0.M2, 3.0.8

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Jan 6, 2017

Thomas Risberg commented

This could be resolved by https://jira.spring.io/browse/SPR-15107

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Jan 12, 2017

Thomas Risberg commented

Once SPR-15107 is merged and available in Spring Framework 4.3.6 we should set the "useNewConnection" flag in the DefaultDataFieldMaxValueIncrementerFactory when we create the MySQLMaxValueIncrementer. Also need to update docs

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Jan 27, 2017

Michael Minella commented

The batch 3.0.x line depends on Spring 4.0.x. It works on the later versions, but we haven’t had a major version to bump the version and I’m not to fond of bumping it in a point release. I've fixed this in the 4.0 line, but am waiting to discuss the 3.x line further.

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Mar 7, 2017

Thomas Risberg commented

Could we use reflection to set the "useNewConnection" value if that method is available? That way we don't have to force 3.x to use the latest Spring Framework 4.3 version

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Mar 7, 2017

Michael Minella commented

That's reasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.