Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename schema-oracle10g to schema-oracle [BATCH-2545] #1057

Open
spring-issuemaster opened this issue Oct 10, 2016 · 2 comments
Open

Rename schema-oracle10g to schema-oracle [BATCH-2545] #1057

spring-issuemaster opened this issue Oct 10, 2016 · 2 comments

Comments

@spring-issuemaster
Copy link
Collaborator

@spring-issuemaster spring-issuemaster commented Oct 10, 2016

Stéphane Nicoll opened BATCH-2545 and commented

I am not sure I understand the reason why the Oracle script is named oracle10g rather than oracle but this leads to some duplicated logic where we have to guess the platform based on the databaseProductName returned by the datasource meta-data.

If we could have oracle as in Spring Session, that would allows us to remove that unnecessary logic.


Affects: 3.0.7

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Oct 10, 2016

Dave Syer commented

It's been like that in Spring Batch since the beginning (i.e. 2007), when 10g was actually new. I don't know if it's a great idea to change it now. Maybe we could add a copy with a different name?

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Oct 10, 2016

Stéphane Nicoll commented

I know it's been like that for a long time. My point is that it's not really relevant anymore. And the duplication logic outside of batch is pretty bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.