Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move RepeatTemplate logger to Trace level [BATCH-2460] #1142

Closed
spring-issuemaster opened this issue Dec 17, 2015 · 3 comments
Closed

Move RepeatTemplate logger to Trace level [BATCH-2460] #1142

spring-issuemaster opened this issue Dec 17, 2015 · 3 comments

Comments

@spring-issuemaster
Copy link
Collaborator

@spring-issuemaster spring-issuemaster commented Dec 17, 2015

Abhinav Nigam opened BATCH-2460 and commented

Hello Mike,

Would it be possible to move the log statements like the one below to move to trace level?

DEBUG o.s.b.repeat.support.RepeatTemplate - Repeat operation about to start at count=176

Thanks
Abhinav


Affects: 3.0.0

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Nov 8, 2018

Mahmoud Ben Hassine commented

I believe debug is the right level for this kind of info (I personally found it helpful in many debug sessions). @Abhinav Nigam Why do you think this should be at trace level?

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Nov 8, 2018

Abhinav Nigam commented

The thought to move this log to trace came to me when I was processing very large files using multi resource partition where each chunk was like 250K or more. During some review sessions, we would have to wait for this log to finish to see the further logs.

On second thought, I think it also gives info at debug log level what batch framework is doing, if moved to trace, the users might think that framework is non-responsive.

Still, in my opinion, it can be moved to trace level.

 

 

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Nov 8, 2018

Mahmoud Ben Hassine commented

Yeah I see, but that's a very specific use case where the debug level would be inappropriate (not because the choice of the log level is inappropriate, but because the use case is unusual: a chunk size of 250k with multi-resource partitions..).

In general, having this repeat information at debug level is better IMHO. BTW, the trace level is almost never used across the entire code base, all debug/trace info is logged with the debug level. So I would keep the log level as is for consistency.

Thank you for your suggestion anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.