Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Move RepeatTemplate logger to Trace level [BATCH-2460] #1142
Abhinav Nigam commented
The thought to move this log to trace came to me when I was processing very large files using multi resource partition where each chunk was like 250K or more. During some review sessions, we would have to wait for this log to finish to see the further logs.
On second thought, I think it also gives info at debug log level what batch framework is doing, if moved to trace, the users might think that framework is non-responsive.
Still, in my opinion, it can be moved to trace level.
Mahmoud Ben Hassine commented
Yeah I see, but that's a very specific use case where the debug level would be inappropriate (not because the choice of the log level is inappropriate, but because the use case is unusual: a chunk size of 250k with multi-resource partitions..).
In general, having this repeat information at debug level is better IMHO. BTW, the trace level is almost never used across the entire code base, all debug/trace info is logged with the debug level. So I would keep the log level as is for consistency.
Thank you for your suggestion anyway.