SimpleJobRepository should ignore non-identifying JobParameters

[spring-projects-issues]

Trevor Baker opened BATCH-2383 and commented

Using the CommandLineJobRunner I pass in some non-identifying parameters but when I rerun with the same parameter, SimpleJobRepository throws an exception:

2015-05-14 12:03:58,414 [ERROR] org.springframework.batch.core.launch.support.CommandLineJobRunner#start:368 | Job Terminated in error: A job instance already exists and is complete for parameters={report.date=1431586800000}.  If you want to run this job again, change the parameters.
org.springframework.batch.core.repository.JobInstanceAlreadyCompleteException: A job instance already exists and is complete for parameters={report.date=1431586800000}.  If you want to run this job again, change the parameters.
        at org.springframework.batch.core.repository.support.SimpleJobRepository.createJobExecution(SimpleJobRepository.java:126)

This is because SimpleJobRepository only checks the number of JobParameters but doesn't check if they are identifying or not.

BatchStatus status = execution.getStatus();
if (execution.getJobParameters().getParameters().size() > 0 && (status == BatchStatus.COMPLETED || status == BatchStatus.ABANDONED)) {
	throw new JobInstanceAlreadyCompleteException(
			"A job instance already exists and is complete for parameters=" + jobParameters
			+ ".  If you want to run this job again, change the parameters.");
}

Related Jira: BATCH-1412

---

Affects: 3.0.3

Attachments:

• SimpleJobRepository.java.patch (596 bytes)

[fmbenhassine]

This is a valid issue, here is a quick way to reproduce it:

import org.springframework.batch.core.Job;
import org.springframework.batch.core.JobParameters;
import org.springframework.batch.core.JobParametersBuilder;
import org.springframework.batch.core.configuration.annotation.EnableBatchProcessing;
import org.springframework.batch.core.configuration.annotation.JobBuilderFactory;
import org.springframework.batch.core.configuration.annotation.StepBuilderFactory;
import org.springframework.batch.core.launch.JobLauncher;
import org.springframework.batch.repeat.RepeatStatus;
import org.springframework.context.ApplicationContext;
import org.springframework.context.annotation.AnnotationConfigApplicationContext;
import org.springframework.context.annotation.Bean;
import org.springframework.context.annotation.Configuration;

@Configuration
@EnableBatchProcessing
public class JobConfig {

    @Bean
    public Job job(JobBuilderFactory jobs, StepBuilderFactory steps) {
        return jobs.get("job")
                .start(steps.get("step")
                        .tasklet((contribution, chunkContext) -> {
                            Object name = chunkContext.getStepContext().getJobParameters().get("name");
                            System.out.println("hello " + name);
                            return RepeatStatus.FINISHED;
                        })
                        .build())
                .build();
    }

    public static void main(String[] args) throws Exception {
        ApplicationContext context = new AnnotationConfigApplicationContext(JobConfig.class);
        JobLauncher jobLauncher = context.getBean(JobLauncher.class);
        Job job = context.getBean(Job.class);
        JobParameters jobParameters = new JobParametersBuilder()
                .addString("name", "foo", false)
                .toJobParameters();
        jobLauncher.run(job, jobParameters);
        jobLauncher.run(job, jobParameters); // fails with: A job instance already exists and is complete for parameters={name=foo}
    }

}

Fixed in 7f0824b by applying a slightly modified version of the attached patch.