Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: ItemFailureLoggerListener Java code doesn't compile [BATCH-2339] #1263

Closed
spring-issuemaster opened this issue Jan 21, 2015 · 1 comment

Comments

@spring-issuemaster
Copy link
Collaborator

@spring-issuemaster spring-issuemaster commented Jan 21, 2015

David MARTIN opened BATCH-2339 and commented

The logger in the code sample doesn't use the right exception name, as specified in the method:

    public void onReadError(Exception ex) {
        logger.error("Encountered error on read", e);
    }

    public void onWriteError(Exception ex, Object item) {
        logger.error("Encountered error on write", e);
    }

It should be 'ex' and not 'e'.


Affects: 3.0.3

Reference URL: http://docs.spring.io/spring-batch/trunk/reference/html/patterns.html#loggingItemProcessingAndFailures

Referenced from: commits e3b7782, 04d167e

@spring-issuemaster
Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Mar 6, 2015

Michael Minella commented

Good catch! Updated and thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.