Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HibernateCriteriaCursorItemReader and HibernateCriteriaItemReaderHelper [BATCH-2308] #1295

Closed
spring-projects-issues opened this issue Oct 7, 2014 · 2 comments
Labels
in: infrastructure status: declined type: enhancement

Comments

@spring-projects-issues
Copy link
Collaborator

spring-projects-issues commented Oct 7, 2014

Bob Fleischman opened BATCH-2308 and commented

I had a need to use Detached criteria for my Spring Batch job so I created the two attached files modeled upon your HibernateCursorItemReader. It has been working for me for more than the last year without a problem, therefore I thought I would contribute it up here should you desire to use it.

I have also included the abstract reader that all of our criteria readers are based upon as well as an example of an implementation.

With the forum deactivated I wasn't sure where else to offer this.

Hope this helps others.


Affects: 2.1.9

Attachments:

@spring-projects-issues
Copy link
Collaborator Author

spring-projects-issues commented Oct 7, 2014

Michael Minella commented

Two things:

  1. Can you please be sure and fill out the contributor's agreement here: https://support.springsource.com/spring_committer_signup
  2. For something like this, a good place to contribute it is the spring-batch-extensions repository found here: https://github.com/spring-projects/spring-batch-extensions. There you can create a pull request with your additions.

@spring-projects-issues
Copy link
Collaborator Author

spring-projects-issues commented Nov 9, 2018

Mahmoud Ben Hassine commented

Hi BobFleischman,

Thank you for your contribution!

As Michael said, please open a PR against the spring-batch-extensions repo with the attached files. We will review it on Github.

Regards,
Mahmoud

@spring-projects-issues spring-projects-issues added status: declined type: enhancement in: infrastructure labels Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: infrastructure status: declined type: enhancement
Projects
None yet
Development

No branches or pull requests

1 participant