Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
SimpleRetryPolicy javadoc is missing some important informations [BATCH-1941] #1651
My usecase was pretty simple:
I wanted a RetryPolicy that would retry all Exception class and subclasses, except a custom exception NoRetryException - which is a RuntimeException - which would make the RetryTemplate abord the retries.
After reading the Javadoc and code of some retry classes of the Retry/Batch framework, I found out that I had to create my custom RetryPolicy.
Finally after loosing some time I noticed something: the use of a TreeSet and of org.springframework.classify.SubclassClassifier.ClassComparator
This means that my usecase was handled by SimpleRetryPolicy, but the Javadoc doesn't mention it. Perhaps for some people it seems to be the obvious behavior, but it was not for me.
The Javadoc doesn't mention this on class level javadoc of BinaryExceptionClassifier and SubclassClassifier too.
"If the object to be classified is one of the keys of the provided
The only Javadoc reference to this feature is:
I think this should be better explained on the SimpleRetryPolicy
The Javadoc of
I believe this is outdated so I'm closing this issue for now. If you think this is not clear enough, please open this issue against