Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExecutionContextUserSupport refers to ItemStream in code and documentation [BATCH-1722] #1862

Closed
spring-issuemaster opened this issue Apr 1, 2011 · 1 comment

Comments

@spring-issuemaster
Copy link
Collaborator

@spring-issuemaster spring-issuemaster commented Apr 1, 2011

Morten Andersen-Gott opened BATCH-1722 and commented

The current implementation of org.springframework.batch.item.util.ExecutionContextUserSupport.getKey(String) looks like this:

public String getKey(String s) {
     Assert.hasLength(name, "ItemStream must have a name assigned.");
     return name + "." + s;
}

The message for suggest this has something to do with ItemStream, which it has not. Theis javadoc for getName and setName also referenced the ItemStream interface.


Affects: 2.1.6

Referenced from: commits 70eb73f

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Apr 3, 2011

Robert Kasanicky commented

In practical terms the ExecutionContextUserSupport was created as a convenience superclass for ItemStream implementations so that's where the ItemStream terminology comes from. But strictly speaking you're right there is no dependency between the two so the javadocs and exception message deserved a cleanup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.