Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Very trivial typos [BATCH-1695] #1891

Closed
spring-issuemaster opened this issue Feb 11, 2011 · 1 comment
Closed

Very trivial typos [BATCH-1695] #1891

spring-issuemaster opened this issue Feb 11, 2011 · 1 comment

Comments

@spring-issuemaster
Copy link
Collaborator

@spring-issuemaster spring-issuemaster commented Feb 11, 2011

Kim, Yong Hwan opened BATCH-1695 and commented

Hello.^^

Thank you for reading spring batch user guide. I think this is very useful, easy for batch programmers.
I have happily read it from start to end for days. ^^

There are two typos I found.

Fisrt.
in 9.2 Retry Policies Tip code

"policy.setFatalExceptions(new Class[] {ILlegalStateException.class}); "
(!!!!!!! )
[ILlegalState->Illegal]

=> to be
policy.setFatalExceptions(new Class[] {IllegalStateException.class});

Second.
in 11.8 Passing Data to Future Steps

"Finally, to the saved values must be retrieved from the Job ExeuctionContext:"

I can understand what "Job ExecutionContext" is mean.
I think "ExcecutionContext of(from) JobExecution" is better than "Job ExecutionContext".

Thanks


Referenced from: commits bea59a7

@spring-issuemaster
Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Feb 12, 2011

Dave Syer commented

I fixed the first one and the grammar in the second. But "Job ExecutionContext" is a term that is used throughout that chapter and it is defined quite carefully, so I didn't change that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.