Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
FieldSetFactory inconsistent parameter ordering create method [BATCH-1662] #1922
The parameter ordering of the interface method FieldSetFactory.create(String, String) is inconsistent with it's DefaultFieldSetFactory implementation and how it's used in AbstractLineTokenizer.
The combinations are:
Somewhat related argument ordering usage:
While it normally might not be a good idea to change interface definitions but the other code, perhaps it's a good idea in this specific case in order to be compatible with existing code which does interact with AbstractLineTokenizer or DefaultFieldSetFactory? It appears that the FieldSetFactory interface is deviating from conventions everywhere else.
Stefan Larsson commented
My suggestion would be to modify FieldSetFactory, just change
As for documentation, the interface methods lack any javadoc, however the method names and arguments are rather self-explanatory in this case.