Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CommandLineJobRunner with RunIdIncrementer adds all previous run parameters [BATCH-1644] #1938

Closed
spring-issuemaster opened this issue Oct 18, 2010 · 1 comment

Comments

@spring-issuemaster
Copy link
Collaborator

@spring-issuemaster spring-issuemaster commented Oct 18, 2010

Jason Lindquist opened BATCH-1644 and commented

When using Spring Batch 2.1.3 with the default JobParametersIncrementer of RunIdIncrementer each run will use all previous Job Parameters even if they have not been specified in the current run. This is an unexpected side effect of #BATCH-1589. The parameter is overriden if specified as a job parameter for the current run.

For example:
Run 1: CommandLineJobRunner job-config.xml jobName -next
-> Job Parameters: {run.id=1}

Run 2: CommandLineJobRunner job-config.xml jobName -next input.test=MyTest
-> Job Parameters: {run.id=2, input.test=MyTest}

Run 3: CommandLineJobRunner job-config.xml jobName -next
-> Job Parameters: {run.id=3, input.test=MyTest}

Run 4: CommandLineJobRunner job-config.xml jobName -next input.test=OtherValue
-> Job Parameters: {run.id=4, input.test=OtherValue}


Affects: 2.1.3

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Oct 18, 2010

Dave Syer commented

It looks like opinions differ as to the usefulness of BATCH-1589. However, I don't see any reason to revert to the old behaviour by default. You can write your own incrementer if you prefer the old behaviour, or we could add a flag that you could set to switch back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.