Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add defensive logging conditionals in performance critical areas of the code base. [BATCH-1630] #1952

Closed
spring-issuemaster opened this issue Sep 18, 2010 · 2 comments

Comments

@spring-issuemaster
Copy link
Collaborator

@spring-issuemaster spring-issuemaster commented Sep 18, 2010

Kyrill Alyoshin opened BATCH-1630 and commented

This is in reference to BATCH-1629.

I have detected a couple of other places where explicit calls to toString show up in the YourKit reports. I will add defensive logging statements to 'core' as I discover such cases. I should submit a patch on Monday.


Affects: 2.1.3

Attachments:

Referenced from: commits d20e518

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Sep 19, 2010

Kyrill Alyoshin commented

There is one more spot in RetryTemplate that shows up here and there in my profiling reports. But it looks like FaultTolerantChunkProcessor was the main culprit. I am attaching the patch for RetryTemplate.

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Sep 26, 2010

Dave Syer commented

Fixed thanks (also changed log level to trace).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.