Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Javadocs: declare that readDate might throw NullPointerException when value is empty [BATCH-1608] #1975

Closed
spring-issuemaster opened this issue Aug 3, 2010 · 2 comments

Comments

@spring-issuemaster
Copy link
Collaborator

@spring-issuemaster spring-issuemaster commented Aug 3, 2010

Alex Beggs opened BATCH-1608 and commented

The readDate call throws an unexpected NullPointerException when the value is null. The documentation does not declare this as the behavior and one should be changed to match the other. See the attached file for the JUnit test file.


Affects: 2.1.2

Attachments:

Referenced from: commits d0abc74

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Aug 7, 2010

Dave Syer commented

I presume the exception comes from DateFormat which itself does not declare or document the NullPointerException, so I think it's a bit pedantic to require all its clients to do so. However, we can always improve the Javadocs...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.