Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StepListenerSupport implements method onErrorInStep which is not declared in any of the implemented interfaces [BATCH-1594] #1990

Closed
spring-issuemaster opened this issue Jul 8, 2010 · 0 comments
Milestone

Comments

@spring-issuemaster
Copy link
Collaborator

@spring-issuemaster spring-issuemaster commented Jul 8, 2010

Morten Andersen-Gott opened BATCH-1594 and commented

The onErrorInStep method is not declared in any of the listener interfaces, nor is it called as far as I can see from the code executing steps. onErrorInStep was removed from the StepExecutionListener in changeset 2338 and jira BATCH-825.

While the onErrorInStep method in StepListenerSupport will not cause problems directly, it is misleading for developers extending StepListenerSupport.

(When editing the StepListenerSupport, you might want to update the non-javadoc referencing StepListener to reference StepExecutionListener instead as well)


Affects: 2.1.1

Referenced from: commits 6aa92ef, 46bff7f, 8efa612

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.