Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method to get all job names to JobExplorer [BATCH-1421] #2159

Closed
spring-issuemaster opened this issue Oct 14, 2009 · 4 comments
Closed

Add method to get all job names to JobExplorer [BATCH-1421] #2159

spring-issuemaster opened this issue Oct 14, 2009 · 4 comments

Comments

@spring-issuemaster
Copy link
Collaborator

@spring-issuemaster spring-issuemaster commented Oct 14, 2009

Morten Andersen-Gott opened BATCH-1421 and commented

The JobExplorer has a lot of nice methods, but there is no point of entry if you don't know the name of a batch job (or a execution/instance id).
If the JobExplorer was extended to include a method getJobNames it would be a good starting point when navigating through the job meta data using JobExplorer (and JobOperator).

It actually seems that someone had this idea at one point, as the JobInstanceDao defines a getJobNames method. However, that method isn't used anywhere from what I've seen (looked for references in eclipse). The improvement should be fairly simple, add a getJobNames-method to the JobExplorer interface that forwards to the JobInstanceDao.getJobNames().

I can create a patch with the proposed solution, if that would make it easier?

There has been talk on the forums lately that people are looking to create an admin console, I belive that this would help them out as well.


Affects: 2.0.1, 2.0.4, 2.1.0.M1

Reference URL: http://forum.springsource.org/showthread.php?t=78956

Referenced from: commits 822f8bb, f2e96f4

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Oct 14, 2009

Dave Syer commented

If you build an admin console (which we have and it will be released soon), you might want to augment JobInstanceDao.getJobNames() with the result from Lista bleJobLocator.getJobNames(). Or you might want to treat those two lists as separately, so both need to be available. I guess the JobExplorer could just call the DAO method if it was documented appropriately. Patches are alwas welcome.

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Oct 15, 2009

Morten Andersen-Gott commented

Will the admin console be springframework or springsource? (open and free? or part of the springsource portfolio with tc and dm)

What will the ListableJobRegistry return that is not in the database? Jobs that have not yet been executed, but that have been registered by a JobRegistryBeanPostProcessor as part of the applicationcontext life cycle?

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Oct 16, 2009

Dave Syer commented

Not sure what you mean about "open and free" (since both tc Server and dm Server are both). The only thing we decided so far is the license (ASL), so I guess that makes it more like Spring than dm Server.

"Jobs that have not yet been executed": yes, precisely. If your admin console can launch jobs it's not much use unless you can list the ones that have not yet been executed.

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Nov 3, 2009

Dave Syer commented

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.