Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing docs in section 4.1 on non-default job repo id for nested step element [BATCH-1233] #2345

Closed
spring-issuemaster opened this issue May 4, 2009 · 3 comments

Comments

@spring-issuemaster
Copy link
Collaborator

@spring-issuemaster spring-issuemaster commented May 4, 2009

Joris Kuipers opened BATCH-1233 and commented

Currently section 4.1 reads:
"The namespace defaults to referencing a repository with an id of 'jobRepository', which is a sensible
default. However, this can be overridden explicitly:

<job id="footballJob" job-repository="specialRepository">
<step id="playerload" parent="s1" next="gameLoad"/>
<step id="gameLoad" parent="s3" next="playerSummarization"/>
<step id="playerSummarization" parent="s3"/>
</job>

Note that if the job repository's default id is overridden, it must be explicitly specified on every Step
as well as on the Job."

However, this example does not specify the job repository's id on every <step> element, as it uses parent references and those step definitions will have the repository id (on their <tasklet>s, not on the <step> itself).
Please clarify that this is not needed for nested <step> elements that are fully configured within the <job> (i.e. that have a <tasklet> subelement).


Affects: 2.0.0

Referenced from: commits f3bc1a0

@spring-issuemaster
Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented May 4, 2009

Dave Syer commented

I think the docos were referring to an older version of the XSD. The JobRepostory is inherited by all the steps in a job so I removed that confusing paragraph. Does that sound sensible?

@spring-issuemaster
Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented May 6, 2009

Joris Kuipers commented

It probably does, although I haven't checked what happens when sharing top-level <step>s across multiple <job>s that each have a different job-repository defined.

@spring-issuemaster
Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented May 6, 2009

Dave Syer commented

OK. Let me know if it works - looking at the code I'd say the job repository is overwritten in the child bean inside the job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.