Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in documentation section 4.2.3 - In-Memory Repository [BATCH-1192] #2376

Closed
spring-issuemaster opened this issue Apr 2, 2009 · 2 comments
Closed

Comments

@spring-issuemaster
Copy link
Collaborator

@spring-issuemaster spring-issuemaster commented Apr 2, 2009

Michel Zanini opened BATCH-1192 and commented

I don't about what was done at the issue BATCH-778, but at the end the class MapJobRepositoryFactoryBean still needs a ResourcelessTransactionManager.

But in documentarion section section 4.2.3 appers as this:

<bean id="jobRepository"
class="org.springframework.batch.core.repository.support.MapJobRepositoryFactoryBean" />

So my advice is to make ResourcelessTransactionManager the default implementation (better) OR make the documentation correct adding the property transactionManager.

Another good option is create something in the namespace like:
<map-job-repository id="jobRepository" />

OR

<job-repository id="jobRepository" type="memory" />


Affects: 2.0.0.RC3

Attachments:

Referenced from: commits 822f8bb, 5c4f590

@spring-issuemaster
Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Apr 7, 2009

Michel Zanini commented

This simple patch defines org.springframework.batch.support.transaction.ResourcelessTransactionManager as default implementation solving the problem.

@spring-issuemaster
Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Apr 7, 2009

Dave Syer commented

Thanks, but I don't think it's really a sensible default because it fools people into thinking they don't need a transaction manager. And I don't want to add support in the namespace because it is really only useful for testing / getting started - not recommended in production use. BATCH-778 was closed because we are not going to make the changes suggested. The documentation, however, has been updated, so I'm marking this issue as Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.