Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message when neither commit-interval nor chunk-completion-policy are specified on a chuck (xml namespace) [BATCH-1202] #2377

Closed
spring-issuemaster opened this issue Apr 9, 2009 · 3 comments

Comments

@spring-issuemaster
Copy link
Collaborator

@spring-issuemaster spring-issuemaster commented Apr 9, 2009

Tareq Abedrabbo opened BATCH-1202 and commented

When neither commit-interval nor chunk-completion-policy are specified on a chuck element, the following error message is output:

Configuration problem: The <chunk/> element must contain either 'commit-interval' or 'chunk-completion-policy', but not both.

The problem is in ChunkElementParser.java, lines 100, 101. The test propertyValues.contains("commitInterval") == propertyValues.contains("chunkCompletionPolicy") returns true if both elements are present or absent.

It would be nicer to distinguish between these 2 cases.


Referenced from: commits 5d303c6

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Apr 12, 2009

Dave Syer commented

Fixed thanks.

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented May 27, 2009

Don Hamson commented

Dave,

While I do get this error, a better report would also tell the id of the chunk/tasklet in error. Depending upon how many steps, we could be poking at things for a while before finding the offending object.

Thanks,
Don

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented May 27, 2009

Dave Syer commented

A chunk or tasklet has no ID so that won't work. If you're using Spring IDE there is a margin marker on the offending line of XML. Beyond that you would need to raise an issue in JIRA for Spring IDE and/or Spring Core to get the line number to come out in stack traces. I'm sure it's doable: just not by us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.