Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch RetryPolicy back to Throwable instead of Exception as in 1.x [BATCH-973] #2604

Closed
spring-issuemaster opened this issue Dec 19, 2008 · 4 comments

Comments

@spring-issuemaster
Copy link
Collaborator

@spring-issuemaster spring-issuemaster commented Dec 19, 2008

Dave Syer opened BATCH-973 and commented

Was: Switch RetryCallback back to Throwable instead of Exception as in 1.x.

A couple of people asked for this (and it makes the RetryOperationsInterceptor easier to implement).


Affects: 2.0.0.M3

Referenced from: commits 6ef8865

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Jan 6, 2009

Dave Syer commented

See discussion in SPR-4855. Not sure if this issue is going to be fixed.

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Jan 12, 2009

Dave Syer commented

Exception is better than Throwable for application developers.

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Sep 23, 2009

Dave Syer commented

I'll take a look at this again for 2.1.

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Sep 23, 2009

Dave Syer commented

It seems that some external libraries (e.g. commons-http) throw Error when they should throw Exception (i.e. it is not fatal and is recoverable). To accommodate that we can change the RetryPolicy signature to enable it to decide to retry a Throwable. The RetryCallback keeps Exception in its signature (hence RetryOperatonsInterceptor is not changed and isn't any easier to implement, but that's not really the priority here).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.