Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SimpleFlatFileInputSource - add a public getter for the "resource" attribute [BATCH-290] #3286

Closed
spring-issuemaster opened this issue Jan 15, 2008 · 4 comments

Comments

@spring-issuemaster
Copy link
Collaborator

@spring-issuemaster spring-issuemaster commented Jan 15, 2008

Anthony Falabella opened BATCH-290 and commented

On the SimpleFlatFileInputSource, currently the "resource" attribute is private and there is no public getter for that attribute. Either add a public getter for it, or make the attribute protected.

It's an attribute that is a main part of the SimpleFlatFileInputSource that most likely developers will want to have access to. Unfortunately as it is, even subclasses cannot get at the attribute.

See http://forum.springframework.org/showthread.php?t=48170


Affects: 1.0-m3

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Jan 24, 2008

Lucas Ward commented

Added a simple getter.

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Jan 28, 2008

Dave Syer commented

Re-opened because public getters are not really best practice for injected dependencies. We'll have to find another way to satisfy this request.

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Jan 28, 2008

Dave Syer commented

Removed it again.

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Aug 7, 2008

Dave Syer commented

Assume closed as resolved and released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.