Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Property default value differs from document [BATCH-2749] #855

Closed
spring-issuemaster opened this issue Sep 4, 2018 · 2 comments
Closed

Property default value differs from document [BATCH-2749] #855

spring-issuemaster opened this issue Sep 4, 2018 · 2 comments

Comments

@spring-issuemaster
Copy link
Collaborator

@spring-issuemaster spring-issuemaster commented Sep 4, 2018

btnoharadik opened BATCH-2749 and commented

The default for the StaxEventItemReader's strict property API document is false, but the default value is set to true.

/**
  * In strict mode the reader will throw an exception on
  * {@link #open(org.springframework.batch.item.ExecutionContext)} if the input resource does not exist.
  * @param strict false by default
  */
 public void setStrict(boolean strict) {
      this.strict = strict;
 }
private boolean strict = true;

Default value is true or false Which is correct?


Affects: 3.0.9, 4.0.1

Referenced from: commits 7a3248c, c075ffc, 9b8a6d1, c96ffb4

Backported to: 4.1.0.RC1, 4.0.2, 3.0.10

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Sep 4, 2018

Mahmoud Ben Hassine commented

That's true, the default is true! :) So the javadoc needs to be updated.

Thank you for reporting this out.

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Sep 4, 2018

Mahmoud Ben Hassine commented

I also checked the StaxEventItemReaderBuilder, just in case. The javadoc is correct in regards to the default value in the builder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.