Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect remote chunking sample in documentation [BATCH-2721] #886

Closed
spring-issuemaster opened this issue May 14, 2018 · 0 comments
Closed

Comments

@spring-issuemaster
Copy link
Collaborator

@spring-issuemaster spring-issuemaster commented May 14, 2018

Mahmoud Ben Hassine opened BATCH-2721 and commented

There are some minor errors in the remote chunking section of the documentation:

  • First, the diagram shows an item reader on the worker side, but in remote chunking, the reading happens on the master side and items are sent over the wire
  • The Step4 label is better if it was Step3
  • The chunkJob method of the code example takes an ItemReader as parameter but uses a method call/reference in the stepBuilderFactory.reader method
  • The chunkHandler bean is not needed on the master side
  • According to the documentation, the middleware has to be durable, but in the code example, we declare the JMS subscription as non durable: .configureListenerContainer(c -> c.subscriptionDurable(false))
  • The term "slave" is better renamed to "worker"

It would be also great to add a remote chunking sample to the spring-batch-samples module.


Affects: 4.0.1

Referenced from: pull request #603, and commits 026bbe0, d69e46e

Backported to: 4.1.0.M1, 4.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.