Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary apache commons-io dependency in spring-batch-test module [BATCH-2698] #909

Closed
spring-issuemaster opened this issue Mar 7, 2018 · 0 comments

Comments

@spring-issuemaster
Copy link
Collaborator

@spring-issuemaster spring-issuemaster commented Mar 7, 2018

Mahmoud Ben Hassine opened BATCH-2698 and commented

The only usage of apache commons io library in spring-batch-test module is in DataSourceInitializer:

scripts = StringUtils.delimitedListToStringArray(stripComments(IOUtils.readLines(scriptResource
							.getInputStream(), "UTF-8")), ";");

Now that v4 is based on Java 8, IOUtils.readLines can be replaced with Files.lines and the dependency to commons io can be removed.


Affects: 4.0.1

Referenced from: pull request #587, and commits 305b4b8, f552607

Backported to: 4.1.0.M3, 4.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.