Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding an encoding(String) method in FlatFileItemReaderBuilder [BATCH-2672] #933

Closed
spring-projects-issues opened this issue Jan 23, 2018 · 0 comments

Comments

@spring-projects-issues
Copy link
Collaborator

Anthony Foulfoin opened BATCH-2672 and commented

Currently we need to build the reader, and then set the encoding:

FlatFileItemReader<Company> reader = new FlatFileItemReaderBuilder<Company>()
        .name("")
        ...
        .build();
reader.setEncoding("ISO-8859-1");

It would be great to add the encoding in the builder flow:

FlatFileItemReader<Company> reader = new FlatFileItemReaderBuilder<Company>()
        .name("")
        .encoding("ISO-8859-1");
        ...
        .build();

Affects: 4.0.0

Referenced from: pull request #569, and commits 8af6841

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant