Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create batch:skip-listeners [BATCH-2627] #978

Open
spring-issuemaster opened this issue Jun 29, 2017 · 0 comments
Open

Create batch:skip-listeners [BATCH-2627] #978

spring-issuemaster opened this issue Jun 29, 2017 · 0 comments

Comments

@spring-issuemaster
Copy link
Collaborator

@spring-issuemaster spring-issuemaster commented Jun 29, 2017

Manuel Jordan opened BATCH-2627 and commented

If currently is possible within a batch:chunk component declare:

<batch:retryable-exception-classes>
	<batch:include class="...SomeException"/>
</batch:retryable-exception-classes>
<batch:retry-listeners>
	<batch:listener ref="personItemRetryListener"/>
</batch:retry-listeners>

Why not is possible do the following?

<batch:skippable-exception-classes>
	<batch:include class="...SomeException"/>
</batch:skippable-exception-classes>
<batch:skip-listeners>
	<batch:listener ref="personItemSkipListener"/>
</batch:skip-listeners>

There is no a batch:skip-listeners element.

Currently I must use the following (observe through batch:listeners}}

<batch:skippable-exception-classes>
	<batch:include class="...SomeException"/>
</batch:skippable-exception-classes>
<batch:listeners>
	<batch:listener ref="personItemSkipListener"/>
	<batch:listener ref="personItemProcessorListener"/>
</batch:listeners>

IMHO batch:listeners should be used for:

  • ItemReadListener
  • ItemProcessListener
  • ItemWriteListener
  • ChunkListener

And thus batch:retry-listeners and batch:skip-listeners clearly more specifics.


Affects: 3.0.6, 3.0.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.