Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getters for collection and mode in MongoItemWriter #3975

Closed
wants to merge 1 commit into from
Closed

Add getters for collection and mode in MongoItemWriter #3975

wants to merge 1 commit into from

Conversation

santfirax
Copy link
Contributor

  • Change access modifiers for collection and delete fields from private to protected in order to be access those when extending a class.
  • Add Getter for collection and delete field in order to access those two fields.

@fmbenhassine
Copy link
Contributor

Rebased and merged as 5e51547. Please note that the delete flag was replaced with an enum in #4351. Therefore, I updated the getter accordingly. Moreover, since we provide getters now, there is no need to make the fields protected (to be consistent with the template field).

Thank you for your contribution!

@fmbenhassine fmbenhassine changed the title Change collection and delete field access modifiers and Add getters f… Add getters for collection and mode in MongoItemWriter Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide accessors in MongoItemWriter to facilitate extensions
2 participants