Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove dead code related to PagingQueryProvider#generateJumpToItemQuery #422

Closed
wants to merge 1 commit into from

Conversation

jpraet
Copy link
Contributor

@jpraet jpraet commented Jun 5, 2016

No description provided.

@pivotal-issuemaster
Copy link

@jpraet Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster
Copy link

@jpraet Thank you for signing the Contributor License Agreement!

@hpoettker
Copy link
Contributor

I think this PR has a lot of merit and it's great that the PR is assigned to the release of Spring Batch 5. The presumeably dead code may not affect users but it does lead to unnecessary work when doing maintenance as e.g. in #4047.

The PR is somewhat out of date and needs some work. Is there interest in a fresh PR with the same goal?

@fmbenhassine
Copy link
Contributor

Yes, I think v5 is a good opportunity to merge this. The PR was based on v3 indeed, so it would be great if it's rebased on the latest main.

Is there interest in a fresh PR with the same goal?

Sure! However, to be fair, I would first ask the original author of the PR if he is willing to update it for v5 (the GA is currently planned for around mid-November 2022), otherwise you can open a fresh PR with the same goal.

@jpraet wdyt?

@fmbenhassine fmbenhassine added the status: waiting-for-reporter Issues for which we are waiting for feedback from the reporter label Sep 23, 2022
@fmbenhassine
Copy link
Contributor

Closing this, superseded by #4207. Thanks to the original author anyway!

@fmbenhassine fmbenhassine added status: superseded Issues that are superseded by other issues and removed status: waiting-for-reporter Issues for which we are waiting for feedback from the reporter labels Oct 5, 2022
@fmbenhassine fmbenhassine removed this from the 5.0.0 milestone Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: infrastructure pr-for: enhancement status: superseded Issues that are superseded by other issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants