New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BATCH-2741] Fix issue - job parameter overwrites #625

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@jojoldu
Copy link

jojoldu commented Aug 8, 2018

Hello?
I recently updated SpringBoot 2.0 with Spring Batch 4.0.
But I think there is a bug.
If the job fails, I keep getting the value of the failed Job Parameter even if I change the value of the Job Parameter with the same key next time.
In 1.5.x, I confirmed that it did not happen, and when I checked the code, it showed a bug in the code and sent a PR

@jojoldu jojoldu changed the title Fixed issue - job parameter overwrites Fix issue - job parameter overwrites Aug 10, 2018

@jojoldu jojoldu changed the title Fix issue - job parameter overwrites [BATCH-2741] Fix issue - job parameter overwrites Sep 6, 2018

@benas benas self-requested a review Oct 10, 2018

@benas

This comment has been minimized.

Copy link
Contributor

benas commented Oct 24, 2018

As explained in BATCH-2711, the method JobParametersBuilder#getNextJobParameters should not deal with restartability anymore after it has been moved to Spring Batch in order to be consistent with CommandLineJobRunner and JobOperator. So the fix in this PR cannot be applied since the method will still deal with restartability. The issue is deeper than just fixing the merge method as in this PR, it should be fixed in both Spring Batch and Spring Boot.

Thank you @jojoldu for your contribution anyway!

@benas benas closed this Oct 24, 2018

@benas benas requested review from benas and removed request for benas Oct 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment