Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
[BATCH-2760] Failed JobExecution due to unavailable TaskExecutor leaves End Time unpopulated #643
On instances when the
…es End Time unpopulated On instances when the taskExecutor is not picking up the submitted Job Execution, with this fix we are explicitly setting the End Time of the JobExecution in order not to give false positives via the JobExplorer#findRunningJobExecutions(). This last method is judging on running Job Executions based on End Time being null.
This PR implies that the job ran when in fact it didn't. Personally, I'd rather see us fix the logic in the places where we evaluate if a job is running to exclude those that haven't started in the first place. We can continue the discussion for this in the Jira issue BATCH-2675. I'm going to close this now until we determine a best course. We can always re-open it if we agree that this is the right path.