From 4cd3bf18e0ad18bf29f7a14d836fea50aca5860e Mon Sep 17 00:00:00 2001 From: Dave Syer Date: Mon, 27 Oct 2014 14:14:25 +0000 Subject: [PATCH] Revert "Updated liquibase dependency to 3.2." This reverts commit d6621e62adbcadec571dbc651c3523384c95724b. I think the test failure might be a bug in Liquibase: https://liquibase.jira.com/browse/CORE-2094 --- spring-boot-dependencies/pom.xml | 2 +- .../SpringPackageScanClassResolver.java | 33 +++++++++++-------- 2 files changed, 20 insertions(+), 15 deletions(-) diff --git a/spring-boot-dependencies/pom.xml b/spring-boot-dependencies/pom.xml index 87b6673a635f..ff19e5a179af 100644 --- a/spring-boot-dependencies/pom.xml +++ b/spring-boot-dependencies/pom.xml @@ -91,7 +91,7 @@ 0.9.1 1.2 4.11 - 3.2.2 + 3.0.8 1.2.17 2.0.2 1.1.2 diff --git a/spring-boot/src/main/java/org/springframework/boot/liquibase/SpringPackageScanClassResolver.java b/spring-boot/src/main/java/org/springframework/boot/liquibase/SpringPackageScanClassResolver.java index 6427015554ec..46e99a037acf 100644 --- a/spring-boot/src/main/java/org/springframework/boot/liquibase/SpringPackageScanClassResolver.java +++ b/spring-boot/src/main/java/org/springframework/boot/liquibase/SpringPackageScanClassResolver.java @@ -47,20 +47,25 @@ public SpringPackageScanClassResolver(Log logger) { this.logger = logger; } - @Override - protected void findAllClasses(String packageName, ClassLoader loader) { - MetadataReaderFactory metadataReaderFactory = new CachingMetadataReaderFactory( - loader); - try { - Resource[] resources = scan(loader, packageName); - for (Resource resource : resources) { - addFoundClass(loadClass(loader, metadataReaderFactory, resource)); - } - } - catch (IOException ex) { - throw new IllegalStateException(ex); - } - } + @Override + protected void find(PackageScanFilter test, String packageName, ClassLoader loader, + Set> classes) { + MetadataReaderFactory metadataReaderFactory = new CachingMetadataReaderFactory( + loader); + try { + Resource[] resources = scan(loader, packageName); + for (Resource resource : resources) { + Class candidate = loadClass(loader, metadataReaderFactory, resource); + if (candidate != null && test.matches(candidate)) { + classes.add(candidate); + } + } + } + catch (IOException ex) { + throw new IllegalStateException(ex); + } + } + private Resource[] scan(ClassLoader loader, String packageName) throws IOException { ResourcePatternResolver resolver = new PathMatchingResourcePatternResolver(loader); String pattern = ResourcePatternResolver.CLASSPATH_ALL_URL_PREFIX